pool: add gominer support. #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug related to sending a set difficulty notification for an unsupported miner.
This adds the decred gominer as a supported mining client.
jholdstock
reviewed
Apr 12, 2021
There was a problem hiding this comment.
I've managed to get gominer running against dcrpool with an RTX 2060, but seeing two issues:
- Difficulty of
2e9seems a bit too high, I don't get any shares from gominer back to dcrpool. I get roughly 1 share per second when I drop diff down to1e6. I suspect an appropriate setting would be somewhere between these two values. - Shares are being rejected by the pool for being lower than the target difficulty. Attaching some logs to demonstrate:
gominer
11:40:14 2021-04-12 [DBG] MINR: GPU #0: Found candidate 0 nonce aeb98075, extraNonce ae0f0000, workID 02000000, timestamp 82237460
11:40:14 2021-04-12 [INF] MINR: DEV #0 Found hash with work below target! 0000000020def659b05a35161663c9c8491d645ecb6c9814b8c59362c362639e (yay)
11:40:14 2021-04-12 [DBG] POOL: Stratum got valid work to submit 090000003fe2e8cb12c9bc32c39d927c03b241d7c0f291d48ef4095bf90407ea00000000b07423ec480d0fc399cb5311ee72c95c44576654eb213e2944d20d9162e7d29f55ed0bb1b9ff4fc881fad06ad2f73ce9f49efe82d575b5daa3b0717008f7202c0100473ea51f6d5f050000004a1300005de8471d1e4be7c10100000076150a006b08000082237460aeb98075ae0f00000200000000000000000000000000000000000000000000000000000009000000000000000000000000000000
11:40:14 2021-04-12 [DBG] POOL: Stratum got valid work hash 0000000020def659b05a35161663c9c8491d645ecb6c9814b8c59362c362639e
11:40:14 2021-04-12 [DBG] MINR: Submitted work to pool successfully: true
11:40:14 2021-04-12 [DBG] POOL: {"id":37,"error":[23,"Low difficulty share: submitted work 924b0dc7a853da12365abf341a5b58cf369ddc05c22f291fb8709140989bf364 from 76909b08/decred-gominer is not less than its corresponding pool target",null],"result":false}
11:40:14 2021-04-12 [ERR] POOL: Share rejected: Low difficulty share: submitted work 924b0dc7a853da12365abf341a5b58cf369ddc05c22f291fb8709140989bf364 from 76909b08/decred-gominer is not less than its corresponding pool target
dcrpool
2021-04-12 10:40:14.345 [DBG] POOL: header is 09000000cbe8e23f32bcc9127c929dc3d741b203d491f2c05b09f48eea0704f939000000b07423ec480d0fc399cb5311ee72c95c44576654eb213e2944d20d9162e7d29f55ed0bb1b9ff4fc881fad06ad2f73ce9f49efe82d575b5daa3b0717008f7202c0100473ea51f6d5f050000004a1300005de8471d1e4be7c10100000076150a006b08000082237460000000000000000000000000000000000000000000000000000000000000000000000000090000008000000100000000000005a0
2021-04-12 10:40:14.345 [DBG] POOL: extraNonce1 is 76909b08
2021-04-12 10:40:14.345 [DBG] POOL: extranonce2 is ae0f00000200000000000000
2021-04-12 10:40:14.345 [DBG] POOL: nTime is 60742382
2021-04-12 10:40:14.345 [DBG] POOL: nonceE is 7580b9ae
2021-04-12 10:40:14.345 [ERR] POOL: submitted work 924b0dc7a853da12365abf341a5b58cf369ddc05c22f291fb8709140989bf364 from 76909b08/decred-gominer is not less than its corresponding pool target
| @@ -597,8 +597,14 @@ func GenerateSolvedBlockHeader(headerE string, extraNonce1E string, | |||
| extraNonce2E string, nTimeE string, nonceE string, miner string) (*wire.BlockHeader, error) { | |||
| headerEB := []byte(headerE) | |||
|
|
|||
| log.Debugf("header is %s\n", headerE) | |||
There was a problem hiding this comment.
Are these \n new lines temporary?
There was a problem hiding this comment.
Yeah they are, I suspected the solved block reconstruction might not be the same as the cpu miner's, outputting them here solely for the values.
dnldd
force-pushed
the
gominer_support
branch
2 times, most recently
from
8aca2ed
to
eb26f57
Compare
|
Closing this since it most definitely won't work as of the latest changes to gominer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #320
This adds the decred gominer as a supported mining client.
Work towards #316.