Setticketsvotebits #39
Conversation
|
are you going to resubmit your PR with fixed EncodeConcatenatedHashes ? I can get this is in if it's ready. |
|
I'm swamped. Sorry |
|
Oh no worries, wasn't trying to nag :) |
chappjc
force-pushed
the
setticketsvotebits
branch
from
5bbafca
to
e9975cb
Compare
|
EncodeConcatenatedHashes actually implemented, but this PR is still untested. |
|
In dcrrpcclient, Unless I'm missing a trick, the slice of hash pointers input to SetTickets... needs to be converted to a slice of hashes. That's not much burden on dcrrpcclient, but it's an extra step I wanted to point out. The alternative is to let Also, it's curious that getTicketsVoteBits in dcrwallet/rpc/legacyrpc takes hashes as a []string instead of concatenated into a single string as setTicketsVoteBits does. No decoding necessary there. |
| // provided by the server. | ||
| func (r FutureSetTicketsVoteBitsResult) Receive() error { | ||
| _, err := receiveFuture(r) | ||
| return err |
There was a problem hiding this comment.
Any reason to use previous?
if err != nil {
return err
}
return nil
There was a problem hiding this comment.
I suppose for readability, but this way is acceptable.
| // provided by the server. | ||
| func (r FutureSetTicketsVoteBitsResult) Receive() error { | ||
| _, err := receiveFuture(r) | ||
| return err |
There was a problem hiding this comment.
I suppose for readability, but this way is acceptable.
For the dcrjson addition: decred/dcrd@cc25399
And the dcrwallet addition:
decred/dcrwallet@781468d
Needs
EncodeConcatenatedHashedin dcrd PR decred/dcrd#429