Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] Derive title from index.md in proposal #115

Closed
sndurkin opened this issue Nov 3, 2017 · 0 comments
Closed

[www] Derive title from index.md in proposal #115

sndurkin opened this issue Nov 3, 2017 · 0 comments

Comments

@sndurkin
Copy link
Contributor

sndurkin commented Nov 3, 2017

Currently the proposal title is not part of the merkle and therefore signature, so it's possible for a user to submit a perfectly valid proposal to Politeia with a bad/offensive title, have it censored, and be able to make a case to others that the valid proposal was unfairly censored.

To address this, the title will be embedded in the index.md file as the first line with text by the client, and www should extract it, strip any markdown characters (if present), and then set it on the ProposalRecord before sending to politeiad.

marcopeereboom pushed a commit that referenced this issue Nov 9, 2017
…) (#126)

backend: added title to ProposalRecord

api: removed 'Name' from the new proposal request & modified other elements

backend: modified proposal tests

tests: included index.md file in the new proposal tests

util: added extra tests to proposal & removed markdown title variables (verbose)

util: added strip func & decoded the file payload - base64

politeiad: removed sanitize call

api: modified doc to remove name from the new proposal req & added name derivation details

util: added util func to get the proposal's title

backend: added title to ProposalRecord

api: removed 'Name' from the new proposal request & modified other elements

backend: modified proposal tests

tests: included index.md file in the new proposal tests

util: added extra tests to proposal & removed markdown title variables (verbose)

util: added strip func & decoded the file payload - base64

politeiad: removed sanitize call

api: wording

api: removed ErrorStatusProposalMissingName & updated error codes

api: removed ErrorStatusProposalMisingName & updated error codes part II

api, tests: modified api & docs to reflect the new errors and created tests for the new errors

util: fixed tests

test: fixed proposal test

error: added context

backend: fixed logic

backend: added context to tests

error: removed json tag

backend: modified title derivation logic

dep: ensure

util, api: modified ProposalName name & error context

util, api: modified ProposalName name & error context part II

test: modified ProposalName to GetProposalName
vibros68 pushed a commit to vibros68/politeia that referenced this issue Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant