Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: Remove all email lookups #860

Closed
lukebp opened this issue May 9, 2019 · 3 comments
Closed

www: Remove all email lookups #860

lukebp opened this issue May 9, 2019 · 3 comments
Assignees
Labels
enhancement The issue enhances an existing feature.

Comments

@lukebp
Copy link
Member

lukebp commented May 9, 2019

We need to go through politeiawww and switch all user lookups by email to be either lookups by username or lookups by userID. This will require that login credentials be switched to username/password instead of email/password. Once all of the user by email lookups have been removed, we can also get rid of the politeiawww userEmails memory cache.

This is part of an effort to make email optional (#554) and to remove all politeiawww memory caches so that multiple politeiawww instances can be run concurrently (#665).

@lukebp lukebp added the enhancement The issue enhances an existing feature. label May 9, 2019
@lukebp lukebp self-assigned this Jun 12, 2019
@lukebp
Copy link
Member Author

lukebp commented Aug 13, 2019

@degeri brought up a good point about switching the login to username. Since usernames are public its possible for someone to lock another user's account via failed login attempts. This could be problematic if a specific user was targeted and kept getting their account locked.

For this reason, we'll be switching the login back to email until 2fa (#544) has been added. 2fa will be required for users that do not have an email address. This will solve the account locking issue detailed above since the login request will only be sent once 2fa has been successfully authenticated.

@lukebp
Copy link
Member Author

lukebp commented Jan 21, 2021

We have decided to fix this a different way. We're going to add a lookup table to the userdb that maps the hashed user email address to the user ID.

This will allow the user to login with either email or username+totp.

@lukebp
Copy link
Member Author

lukebp commented Apr 29, 2021

Closing this issue due to inactivity or because it was included in the v1.0.0. If you feel this issue is still relevant, please re-open it to bring it to our attention.

@lukebp lukebp closed this as completed Apr 29, 2021
vibros68 pushed a commit to vibros68/politeia that referenced this issue Aug 17, 2021
* Fix Manage Identity identation

* Update GeneralTab.js

* Update GeneralTab.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue enhances an existing feature.
Projects
None yet
Development

No branches or pull requests

1 participant