[www] Add paging capability to proposal list routes #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndurkin
force-pushed
the
paging
branch
2 times, most recently
from
6b94508
to
120c895
Compare
marcopeereboom
suggested changes
Nov 13, 2017
sndurkin
force-pushed
the
paging
branch
2 times, most recently
from
0e3ab7c
to
302f345
Compare
sndurkin
changed the title
|
@marcopeereboom updated refclient and API docs, it's ready for re-review. |
rgeraldes
suggested changes
Nov 18, 2017
politeiawww/backend.go
Outdated
|
|
||
| // Iterate in reverse order because they're sorted by oldest timestamp first. | ||
| for i := len(b.inventory) - 1; i >= 0; i-- { | ||
| p := b.inventory[i] |
politeiawww/backend.go
Outdated
| for i := len(b.inventory) - 1; i >= 0; i-- { | ||
| p := b.inventory[i] | ||
| if _, ok := statusMap[p.Status]; ok { | ||
| if pageStarted { |
There was a problem hiding this comment.
switch { in place of if-else chains (idiomatic)
There was a problem hiding this comment.
as a result the break needs to be changed to break "TAG Before the for like this 'tag:'".
politeiawww/backend.go
Outdated
| // If beforeIdx is set, the caller is asking for vetted proposals whose | ||
| // last result is before the provided proposal. | ||
| if beforeIdx >= 0 { | ||
| for i := beforeIdx + 1; i < len(b.inventory); i++ { |
There was a problem hiding this comment.
change for range b.inventory [beforeIdx + 1:]
marcopeereboom
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
/vettedand/unvettedroutesv1.ProposalListPageSizeFixes #43.