Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import proto/sign to lib/sign #49

Closed
ineiti opened this issue Nov 2, 2015 · 3 comments
Closed

Import proto/sign to lib/sign #49

ineiti opened this issue Nov 2, 2015 · 3 comments

Comments

@ineiti
Copy link
Member

ineiti commented Nov 2, 2015

Re-think the usefulness of the proto-directory - is it OK to just port it back to the lib-directory? Should it be done in a way that we can import proto/sign or import proto/randhound or import proto/shamir and this way clean up the app/*-directory? This way the proto-directory could be used directly by third-party apps.

Or we just throw away the proto-directory and include it in sign

@nikkolasg
Copy link
Contributor

By port you mean proto ?
I agree it could be nice to do these kinds of imports. But proto/sign is very closely related to lib/conode and could maybe be merged with lib/conode instead of a new sub package.

@ineiti ineiti changed the title Import port/sign to lib/sign Import prort/sign to lib/sign Nov 2, 2015
@ineiti ineiti changed the title Import prort/sign to lib/sign Import proto/sign to lib/sign Nov 2, 2015
@ineiti
Copy link
Member Author

ineiti commented Nov 2, 2015

Of course - corrected title and message.

And would you prefer throwing away the proto-directory or rather have proto/(conode|randhound|shamir|simple)?

@ineiti
Copy link
Member Author

ineiti commented Nov 19, 2015

Closed in #59

@ineiti ineiti closed this as completed Nov 19, 2015
jeffallen pushed a commit that referenced this issue Jun 6, 2018
Initial architecture for adding genesis block/darc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants