Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline #18

Closed
wants to merge 36 commits into from
Closed

Baseline #18

wants to merge 36 commits into from

Conversation

nikkolasg
Copy link
Contributor

This is the branch where I develop the other baseline such as the naive baseline where one leader ask the signature of all others servers (and check all of them).

@ineiti
Copy link
Member

ineiti commented Oct 5, 2015

Merge with the restructure_mains branch to update the .gitignore which will ignore the “deploy/platform/localhost/*"

On 05 Oct 2015, at 16:52, nikkolasg notifications@github.com wrote:

This is the branch where I develop the other baseline such as the naive baseline where one leader ask the signature of all others servers (and check all of them).

You can view, comment on, or merge this pull request online at:

#18 #18
Commit Summary

First draft on network-layer library
Merge branch 'networking' into baseline
Sketch of the naive baseline
finished impl.
running but wrong port.Must change networking before
listen now takes an addr to listen to
Merge branch 'networking' into baseline
naive baseline working
merged restructure mains
1st baseline functional
File Changes

M .gitignore https://github.com/DeDiS/cothority/pull/18/files#diff-0 (2)
A app/naive/crypto.go https://github.com/DeDiS/cothority/pull/18/files#diff-1 (62)
A app/naive/naive.go https://github.com/DeDiS/cothority/pull/18/files#diff-2 (21)
A app/naive/peer.go https://github.com/DeDiS/cothority/pull/18/files#diff-3 (156)
A app/naive/server.go https://github.com/DeDiS/cothority/pull/18/files#diff-4 (96)
M app/shamir/shamir.go https://github.com/DeDiS/cothority/pull/18/files#diff-5 (2)
M deploy/platform/localhost.go https://github.com/DeDiS/cothority/pull/18/files#diff-6 (9)
A deploy/platform/localhost/app.toml https://github.com/DeDiS/cothority/pull/18/files#diff-7 (5)
A deploy/platform/localhost/localhost.toml https://github.com/DeDiS/cothority/pull/18/files#diff-8 (8)
A deploy/simulation/naive_single.toml https://github.com/DeDiS/cothority/pull/18/files#diff-9 (7)
A lib/app/config_naive_sign.go https://github.com/DeDiS/cothority/pull/18/files#diff-10 (17)
A lib/network_draft/gobs.go https://github.com/DeDiS/cothority/pull/18/files#diff-11 (150)
A lib/network_draft/network/net.go https://github.com/DeDiS/cothority/pull/18/files#diff-12 (224)
Patch Links:

https://github.com/DeDiS/cothority/pull/18.patch https://github.com/DeDiS/cothority/pull/18.patch
https://github.com/DeDiS/cothority/pull/18.diff https://github.com/DeDiS/cothority/pull/18.diff

Reply to this email directly or view it on GitHub #18.

@nikkolasg
Copy link
Contributor Author

It is already present in the .gitignore. (?)

@ineiti
Copy link
Member

ineiti commented Oct 5, 2015

Then delete the files from git... I think the .gitignore got updated AFTER the files were added. About the git commit -am - I always do a git status before the commit command, so I see if other files will be included!

@nikkolasg
Copy link
Contributor Author

RIght sorry didn't catch up those files ><

@bford
Copy link

bford commented Oct 6, 2015

Awesome, thanks - and sorry I haven't been able to keep up with stuff while I'm in the thick of this conference. Have you been able to run an experiment with this code comparable to the others, and if so, Linus, can you add the resulting dataset to the graphs you plotted for me? (Sorry if it's already in my inbox and I just haven't gotten to it yet! ;) )

@ineiti
Copy link
Member

ineiti commented Oct 6, 2015

The experiment is being run, but not yet at 8192 nodes...

@ineiti ineiti mentioned this pull request Oct 7, 2015
@ineiti
Copy link
Member

ineiti commented Oct 7, 2015

Just to include the offline-discussion in this issue. Bryan said:

By this I meant that it uses the same communication pattern as the Cothority scheme - i.e., nodes in the (same) tree communicate only with their immediate parent and children - but instead of true collective signing, the nodes just aggregate individual signatures going up the tree. To be more specific, this protocol could probably just operate in a single “round-trip” over the tree rather than the two round-trips that the Cothority needs: (1) the leader announces the message to be signed, and it propagates downward through the tree to the leaves as a straight multicast message; then (2) each leaf produces a conventional, individual signature on the message with its public key and sends its signature up to its parent node, and intermediate nodes simply concatenate these signatures together into lists (and add their own individual signatures) going up the tree; and (3) finally the root simply receives a long list of individual signatures from all the nodes that were present in the tree; this whole list is now the “naive” collective signature, which anyone may check simply by checking all the individual signatures.

Like I said it’s not necessarily essential to have this, but if it’s easy to hack together quickly as a variant, it would be helpful because it would allow us to separate and measure precisely the performance benefit we get from (a) using the efficient communication tree, and (b) using the multisignature crypto magic. These are logically separate and orthogonal optimizations that we implement (either could be implemented without the other), and it’s just good practice in experimental research to try to separate orthogonal improvements or optimizations like these and give the reader of a paper a sense for which are more or less important in the big picture, etc.

@ineiti
Copy link
Member

ineiti commented Oct 8, 2015

Closing - continue in #30

@ineiti ineiti closed this Oct 8, 2015
@ineiti ineiti mentioned this pull request Oct 8, 2015
ineiti pushed a commit that referenced this pull request Mar 12, 2018
* Fix in creating connection based on TOML format

* Fix in getSkipblock method.

* Data interfaces for further API modification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants