adds wss to bcadmin debug #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
bcadmin_debug_wss
branch
4 times, most recently
from
fd0c57f
to
f947cf5
Compare
jeffallen
reviewed
May 1, 2019
There was a problem hiding this comment.
I appreciate your help with bcadmin, but something's gone off the rails here. This seems like it violates "don't repeat yourself" and "Go packages have a reason to exist, not just to be dumping ground for util functions". Please help me understand why I'm misunderstanding what you are trying to do here...
|
OK, the plan is:
|
ineiti
force-pushed
the
bcadmin_debug_wss
branch
2 times, most recently
from
cf74525
to
81065fd
Compare
|
Onet tag v3.0.8 is ready for you to use. |
bcadmin now wants a URL for bcadmin debug, so it's http://conode.dedis.ch:7771 or https://conode.dedis.ch Added more details in bcadmin debug list for the byzcoins of each node. Can now give group.toml to bcadmin debug list, to check on a list of servers. Wallet correctly connects to wss if available and stores URL field in wallet.json.
jeffallen
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bcadmin now wants a
URLforbcadmin debug, so it'shttp://conode.dedis.ch:7771orhttps://conode.dedis.chAdded more details in bcadmin debug list for the byzcoins of each node.
Can now give group.toml to bcadmin debug list, to check on a list of servers.