Fixes timeout in Websocket #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharvik
reviewed
Nov 20, 2020
Yes, I'm on it. |
Clearing the timeout doesn't set it back. This would make the websocket connection have a connection error (coming from Onet I guess..?) instead of the expected timeout. Also added a `npm run watch` to automatically compile files on changes. Fixes dedis/columbus-united#40
ineiti
approved these changes
Nov 20, 2020
|
It's still in WIP, so I'll not merge it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing the timeout doesn't set it back. This would make the websocket connection have a connection error (coming from Onet I guess..?) instead of the expected timeout.
Also added a
npm run watchto automatically compile files on changes.Fixes dedis/columbus-united#40