Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memcoin proxy start is not idempotent #34

Open
augustebaum opened this issue Jan 14, 2022 · 0 comments
Open

memcoin proxy start is not idempotent #34

augustebaum opened this issue Jan 14, 2022 · 0 comments

Comments

@augustebaum
Copy link
Contributor

To reproduce:

  1. In the project root, run start_test.sh.
  2. In the pane not reserved for the running nodes, run all the commands in setup.sh until
memcoin --config /tmp/node1 proxy start --clientaddr 127.0.0.1:8081
  1. Run this command now. Everything should work.
  2. Run this command again. Node 1 panics with the following stack trace:
<datetime> PNC /path/to/go/pkg/mod/go.dedis.ch/dela@v0.0.0-20211018150429-1fdbe35cd189/mino/proxy/http/mod.go:108 >
failed to create conn '127.0.0.1:8081': listen tcp 127.0.0.1:8081: bind: address already in use role="http proxy"
panic: failed to create conn '127.0.0.1:8081': listen tcp 127.0.0.1:8081: bind: address already in use

goroutine 438 [running]:
github.com/rs/zerolog.(*Logger).Panic.func1({0xc0000b0d20, 0x0})
        /path/to/go/pkg/mod/github.com/rs/zerolog@v1.19.0/log.go:342 +0x2d
github.com/rs/zerolog.(*Event).msg(0xc0004a6c00, {0xc0000b0d20, 0x5f})
        /path/to/go/pkg/mod/github.com/rs/zerolog@v1.19.0/event.go:147 +0x2b8
github.com/rs/zerolog.(*Event).Msgf(0xc0004a6c00, {0x1738dc3, 0xc00038a3d0}, {0xc000063f98, 0xc00038a270, 0xc00038a3a8})
        /path/to/go/pkg/mod/github.com/rs/zerolog@v1.19.0/event.go:127 +0x4e
go.dedis.ch/dela/mino/proxy/http.(*HTTP).Listen(0xc0000aa3f0)
        /path/to/go/pkg/mod/go.dedis.ch/dela@v0.0.0-20211018150429-1fdbe35cd189/mino/proxy/http/mod.go:108 +0x3be
created by go.dedis.ch/dela/mino/proxy/http/controller.startAction.Execute
        /path/to/go/pkg/mod/go.dedis.ch/dela@v0.0.0-20211018150429-1fdbe35cd189/mino/proxy/http/controller/action.go:28 +0xf4
	
panic: failed to create conn '127.0.0.1:8081': listen tcp 127.0.0.1:8081: bind: address already in use

goroutine 282 [running]:
github.com/rs/zerolog.(*Logger).Panic.func1({0xc0000430e0, 0x0})
        /path/to/go/pkg/mod/github.com/rs/zerolog@v1.19.0/log.go:342 +0x2d
github.com/rs/zerolog.(*Event).msg(0xc000032fc0, {0xc0000430e0, 0x5f})
        /path/to/go/pkg/mod/github.com/rs/zerolog@v1.19.0/event.go:147 +0x2b8
github.com/rs/zerolog.(*Event).Msgf(0xc000032fc0, {0x171d6be, 0xc00003e4d0}, {0xc00009ef98, 0x0, 0xc00003e468})
        /path/to/go/pkg/mod/github.com/rs/zerolog@v1.19.0/event.go:127 +0x4e
go.dedis.ch/dela/mino/proxy/http.(*HTTP).Listen(0xc0001d6240)
        /path/to/go/pkg/mod/go.dedis.ch/dela@v0.0.0-20211018150429-1fdbe35cd189/mino/proxy/http/mod.go:108 +0x3be
created by go.dedis.ch/dela/mino/proxy/http/controller.startAction.Execute
        /path/to/go/pkg/mod/go.dedis.ch/dela@v0.0.0-20211018150429-1fdbe35cd189/mino/proxy/http/controller/action.go:28 +0xf4

We'd expect it not to crash.

ineiti added a commit that referenced this issue Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant