Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change back question ID length to 8 bytes #149

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Change back question ID length to 8 bytes #149

merged 1 commit into from
Jun 22, 2022

Conversation

cmsigrist
Copy link
Contributor

Change the ID length of questions during Election create back to 8 bytes.

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2541007356

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.5%) to 60.393%

Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 13 84.84%
services/shuffle/neff/handler.go 14 79.63%
Totals Coverage Status
Change from base Build 2535659071: -0.5%
Covered Lines: 2978
Relevant Lines: 4931

💛 - Coveralls

@nkcr nkcr merged commit 927c581 into main Jun 22, 2022
@nkcr nkcr deleted the front-id-length branch June 22, 2022 09:09
ineiti pushed a commit that referenced this pull request Oct 10, 2024
fix: add missing JSON/schema validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants