Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull from the main #226

Merged
merged 144 commits into from
Nov 28, 2022
Merged

Pull from the main #226

merged 144 commits into from
Nov 28, 2022

Conversation

Ghita2002
Copy link
Contributor

No description provided.

aelalamy42 and others added 30 commits September 30, 2022 16:12
From meeting-1-production-readiness to week-1-production-readiness
It is now a markdown file named week-1-production-readiness.md
The title of  the last part wasn't correct
first meeting of the production-readiness team
defined constants for the most duplicated strings (select, rank, text and
the string used when an answer could not be marshaled) to reduce code smells.
Added a specific string related to each kind of question to avoid hardcoding them and a getter for these strings in the Interface Question + corrected constants in the tests
add meeting notes for security auditing week 2,3,4
@Ghita2002 Ghita2002 marked this pull request as ready for review November 28, 2022 18:48
@Ghita2002 Ghita2002 merged commit d03ce68 into d-voting_frontend_ghita Nov 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3567714449

  • 62 of 209 (29.67%) changed or added relevant lines in 9 files are covered.
  • 268 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.05%) to 56.825%

Changes Missing Coverage Covered Lines Changed/Added Lines %
services/dkg/pedersen/controller/action.go 0 1 0.0%
proxy/shuffle.go 0 2 0.0%
proxy/dkg.go 10 20 50.0%
proxy/election.go 0 19 0.0%
contracts/evoting/controller/action.go 0 115 0.0%
Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/controller/action.go 3 48.97%
services/dkg/pedersen/handler.go 3 87.23%
contracts/evoting/types/ballots.go 4 98.91%
proxy/shuffle.go 7 0%
cli/cosipbftcontroller/mod.go 10 94.08%
proxy/dkg.go 32 34.29%
proxy/election.go 98 1.17%
contracts/evoting/controller/action.go 111 0%
Totals Coverage Status
Change from base Build 3567579641: -0.05%
Covered Lines: 3272
Relevant Lines: 5758

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants