-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promises #40
Promises #40
Conversation
I finished my first attempt at trying to write BinaryMarshal/ BinaryUnmarshal for a cryptographic object (PromiseSignature). Before I move on to writing the marshalling code for Promise, it would be helpful if you could offer suggestions on how I handled the PromiseSignature marshalling. Could you look over the code when you get a chance? |
* Returns | ||
* An initialized PromiseSignature ready to be unmarshalled | ||
*/ | ||
func (p *PromiseSignature) UnMarshalInit(suite abstract.Suite) *PromiseSignature { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unmarshal is typically spelled with only the U and not the M capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I responded to the changes you mentioned and asked some additional questions. I've altered the code to produce a new version. Could you look over them when you get a chance and let me know if you would like me to change the code more? I'll proofread the documentation again after I've made all the changes you like |
William, just noticed - your comment-writing style is incompatible with godoc and produces all kinds of bad effects. See for example: http://godoc.org/github.com/DeDiS/crypto/poly/promise Can you fix this? You can start your own godoc server locally via: '''godoc -http=:6060''' and edit your code-comments appropriately until the resulting godoc output looks decent. Thanks! B |
@bford
@jackowitzd2
This is the branch in which I am working on the cryptographic object for the insurance policy. I opened up this pull request to serve as a forum of discussion while I work. Please feel free to make comments/ suggestions as I develop.