Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises #40

Merged
merged 63 commits into from
May 1, 2015
Merged

Promises #40

merged 63 commits into from
May 1, 2015

Conversation

WEB3-GForce
Copy link

@bford
@jackowitzd2

This is the branch in which I am working on the cryptographic object for the insurance policy. I opened up this pull request to serve as a forum of discussion while I work. Please feel free to make comments/ suggestions as I develop.

@WEB3-GForce WEB3-GForce mentioned this pull request Feb 28, 2015
@WEB3-GForce
Copy link
Author

@bford

I finished my first attempt at trying to write BinaryMarshal/ BinaryUnmarshal for a cryptographic object (PromiseSignature). Before I move on to writing the marshalling code for Promise, it would be helpful if you could offer suggestions on how I handled the PromiseSignature marshalling. Could you look over the code when you get a chance?

* Returns
* An initialized PromiseSignature ready to be unmarshalled
*/
func (p *PromiseSignature) UnMarshalInit(suite abstract.Suite) *PromiseSignature {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unmarshal is typically spelled with only the U and not the M capitalized.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@WEB3-GForce
Copy link
Author

@bford

I responded to the changes you mentioned and asked some additional questions. I've altered the code to produce a new version. Could you look over them when you get a chance and let me know if you would like me to change the code more?

I'll proofread the documentation again after I've made all the changes you like

@WEB3-GForce
Copy link
Author

@bford
@davidiw

I've added a few more features to Promise so that it could support the networking code properly. It now has all the features to support the first networking version.

The code has been tested and ready for merge after any additional reviews that you would like to do.

bford added a commit that referenced this pull request May 1, 2015
Great work, thanks William!
@bford bford merged commit decec10 into dedis:master May 1, 2015
@bford
Copy link
Contributor

bford commented May 4, 2015

William, just noticed - your comment-writing style is incompatible with godoc and produces all kinds of bad effects. See for example:

http://godoc.org/github.com/DeDiS/crypto/poly/promise

Can you fix this? You can start your own godoc server locally via:

'''godoc -http=:6060'''

and edit your code-comments appropriately until the resulting godoc output looks decent. Thanks!

B

ineiti added a commit that referenced this pull request Mar 19, 2018
armfazh pushed a commit to armfazh/kyber that referenced this pull request Apr 13, 2023
armfazh pushed a commit to armfazh/kyber that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants