Updating documentation of Rabin/vss.go and Pedersen/vss.go #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the description of MinimumT and NewDealer.
Fixed typo
Reworded pedersen MinimumT and NewDealer
|
|
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
2 similar comments
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
ineiti
approved these changes
Aug 29, 2023
|
Thanks a lot for creating this PR! |
pierluca
reviewed
Aug 30, 2023
Co-authored-by: pierluca <pierluca@users.noreply.github.com>
Co-authored-by: pierluca <pierluca@users.noreply.github.com>
Co-authored-by: pierluca <pierluca@users.noreply.github.com>
Co-authored-by: pierluca <pierluca@users.noreply.github.com>
|
@pierluca added your suggestions as commits, I think this can be merged now. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code comments now reflect the conclusions drawn in #474
Closes #474