support ConstExprNode node to avoid crashing with 500

[ildyria]

This allows the AST parser to not break on a ConstExprNode when going through documentation.

[romalytvynenko]

@ildyria Thanks for the fix!

Can you please share an example of the PhpDoc that causes this fail?

Thanks!

[ildyria]

@ildyria Thanks for the fix!

Can you please share an example of the PhpDoc that causes this fail?

Thanks!

That is going to be difficult to find, I am using scramble as direct plug on https://github.com/LycheeOrg/Lychee and the project is quite big. I will try to find one.

[ildyria]

Found it. This will crash.

	/**
	 * Reset the token of the currently authenticated user.
	 *
	 * @return array{'token': string}
	 *
	 * @throws UnauthenticatedException
	 * @throws ModelDBException
	 * @throws \Exception
	 */
	public function resetToken(): array
{...}

This will pass.

	/**
	 * Reset the token of the currently authenticated user.
	 *
	 * @return array
	 *
	 * @throws UnauthenticatedException
	 * @throws ModelDBException
	 * @throws \Exception
	 */
	public function resetToken(): array
{...}

Note that this is valid and follows https://phpstan.org/writing-php-code/phpdoc-types#array-shapes

[romalytvynenko]

I see.

But as far as I can tell, suggested fix will result in loosing type information.

I believe that it should be a more comprehensive support of the const expressions in PhpDoc (which will result in a correct type).

So the PhpDoc comment:

/**
 * @var $foo array{'token': string}
 */

Should become type:

array{token: string}

With the suggested fix it will become an unknown type key:

array{unknown: string}

[ildyria]

Said function is:

	/**
	 * Reset the token of the currently authenticated user.
	 *
	 * @return array{'token': string}
	 *
	 * @throws UnauthenticatedException
	 * @throws ModelDBException
	 * @throws \Exception
	 */
	public function resetToken(): array
	{
		/** @var User $user */
		$user = Auth::user() ?? throw new UnauthenticatedException();
		$token = strtr(base64_encode(random_bytes(16)), '+/', '-_');
		$user->token = hash('SHA512', $token);
		$user->save();

		return ['token' => $token];
	}

With this patch, the doc becomes:

I believe that it should be a more comprehensive support of the const expressions in PhpDoc (which will result in a correct type).

I would agree, but I am not that familiar with the code base and php node parsing. :|

[romalytvynenko]

With this patch, the doc becomes:...

Yeah, but the information is inferred from the code in this case, not from the comment:

return ['token' => $token];

I would agree, but I am not familiar with the code base. :|

That's fine, I will do it in the next release.

For now you can change PhpDoc comment to this (notice no ', which is an equivalent of the comment you have):

/**
 * @return array{token: string}
 */

I will add const expressions support in the next release.

Thanks.

[romalytvynenko]

Fixed in #59