Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearify the use of Spring BOM in deegree root POM dependencyManagement section #1718

Open
tfr42 opened this issue Jun 18, 2024 · 1 comment
Labels
TMC discussion to be discussed by technical management committee members

Comments

@tfr42
Copy link
Member

tfr42 commented Jun 18, 2024

Currently the Spring Boot BOM is used in the project root POM in the dependencyManagement section (see https://github.com/deegree/deegree3/blob/main/pom.xml#L1206) which will import the versions defined by the Spring Boot BOM. This may override versions used in modules such as the deegree-webservices which uses the dependencies also defined in the dependencyManagement section of the root project POM.

Proposal:

@tfr42 tfr42 added the TMC discussion to be discussed by technical management committee members label Jun 18, 2024
@stephanr
Copy link
Member

I also think it is not a good idea to mix the spring-boot-dependencies BOM with the deegree dependencies, as there are overlaps between both dependency lists.

Moving the BOM import into the deegree-tools-gml submodule will certainly move the issue regarding overlapping dependency declaration and the resulting dependency issues into the submodule and won't interfere with most of the modules anymore. But this won't solve issues in that module if spring-boot-dependencies and the root pom will define different versions for dependencies (overlaps).

An alternative proposal would be to not import spring-boot-dependencies anymore and instead use only the BOM's which are limited to spring dependencies (for example 1, 2) and define required external dependencies with dependency management as we do with all other libs as well.
The only downside is, that we have to ensure that the overlapping dependencies will not diverge too much from the spring declared ones (which can be lookup up in spring-boot-dependencies).

  1. https://search.maven.org/artifact/org.springframework/spring-framework-bom/6.1.9/pom
  2. https://search.maven.org/artifact/org.springframework.data/spring-data-bom/2024.0.1/pom

tfr42 added a commit to lat-lon/deegree3 that referenced this issue Jul 19, 2024
copierrj added a commit to copierrj/deegree3 that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TMC discussion to be discussed by technical management committee members
Projects
None yet
Development

No branches or pull requests

2 participants