-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test detectors on an OOD task #49
Conversation
80b5436
to
1ef4a0b
Compare
1ef4a0b
to
180ac46
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Note: change `model_name` arg to `model` in train model functions, so had to edit every files calling this function
180ac46
to
7f73c5e
Compare
7f73c5e
to
ea241f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So efficient! LGTM. Very smart to have put everything in one common eval_detector_on_blobs
, writing tests for future baselines will be way faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good
To sum up
torch_methods_utils.py
andtf_methods_utils.py
(seeeval_detector_on_blobs
function).