Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test detectors on an OOD task #49

Merged
merged 10 commits into from
Jun 7, 2023
Merged

Test detectors on an OOD task #49

merged 10 commits into from
Jun 7, 2023

Conversation

y-prudent
Copy link
Member

@y-prudent y-prudent commented Jun 5, 2023

To sum up

  • Previously, tests for baselines were very basic and only consisted in shapes tests.
  • Now, each baseline is evaluated on a 2D toy test case (4 blobs: 2 ID and 2 OOD => see figure below), where some assertions ensure that we get systematically an AUROC > 0.95 and an FPR95TPR < 0.05.
    • Model chosen for tf and torch is a simple MLP (1 hidden layer) loaded from an url for reproducibility.
    • Most important files: torch_methods_utils.py and tf_methods_utils.py (see eval_detector_on_blobs function).

blob_toy_dataset

@y-prudent y-prudent changed the title Test/eval methods on toy uc Test detectors on an OOD task Jun 5, 2023
@y-prudent y-prudent force-pushed the test/eval_methods_on_toy_uc branch 6 times, most recently from 80b5436 to 1ef4a0b Compare June 5, 2023 21:12
@y-prudent y-prudent marked this pull request as draft June 6, 2023 09:02
@y-prudent y-prudent force-pushed the test/eval_methods_on_toy_uc branch from 1ef4a0b to 180ac46 Compare June 6, 2023 12:57
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1614 1446 90% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
oodeel/utils/tf_training_tools.py 71% 🟢
oodeel/utils/torch_training_tools.py 92% 🟢
TOTAL 82% 🟢

updated for commit: ea241f7 by action🐍

@y-prudent y-prudent force-pushed the test/eval_methods_on_toy_uc branch from 180ac46 to 7f73c5e Compare June 6, 2023 19:03
@y-prudent y-prudent mentioned this pull request Jun 6, 2023
2 tasks
@y-prudent y-prudent force-pushed the test/eval_methods_on_toy_uc branch from 7f73c5e to ea241f7 Compare June 7, 2023 14:17
@y-prudent y-prudent marked this pull request as ready for review June 7, 2023 14:21
Copy link
Member

@paulnovello paulnovello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So efficient! LGTM. Very smart to have put everything in one common eval_detector_on_blobs, writing tests for future baselines will be way faster.

Copy link
Contributor

@cofri cofri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good

@cofri cofri merged commit c87e08d into master Jun 7, 2023
@cofri cofri deleted the test/eval_methods_on_toy_uc branch June 7, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants