Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/feedback louis #60

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Fix/feedback louis #60

merged 4 commits into from
Aug 24, 2023

Conversation

y-prudent
Copy link
Member

A few fixes in response to Louis feedback:

  • In the tutorial section of the doc: MLP / MSP lead to the Getting started tutorial, it would be more logical to return a link for separate torch and tf MLP / MSP notebooks.
  • In readme and index.md, add a note about prepare-dev-torch and prepare-dev-tf for users that want an installation for a specific backend.
  • In index.md, the title "For benchmarking with one dataset as in-distribution and another as out distribution" appears 2 times
  • Fix broken links in the doc, and remove the link leading to the main doc page from the main doc page (for instance "You can find the doc here" => useless)

@y-prudent y-prudent linked an issue Aug 24, 2023 that may be closed by this pull request
Apply feedback from Louis #58
Closed
@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1877 1701 91% 70% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: aab65dc by action🐍

paulnovello
paulnovello requested changes Aug 24, 2023
View reviewed changes
docs/pages/operator_tuto.md Outdated Show resolved Hide resolved
docs/pages/operator_tuto.md Outdated Show resolved Hide resolved
cofri
cofri approved these changes Aug 24, 2023
View reviewed changes
README.md Show resolved Hide resolved
paulnovello
paulnovello approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@paulnovello paulnovello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulnovello paulnovello merged commit 016c6f4 into master Aug 24, 2023
10 checks passed
@y-prudent y-prudent deleted the fix/feedback_louis branch August 25, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulnovello paulnovello paulnovello approved these changes

@cofri cofri cofri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply feedback from Louis
3 participants
@y-prudent @cofri @paulnovello