Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build workflows #517

Closed
m-reuter opened this issue May 1, 2024 · 5 comments
Closed

Docker build workflows #517

m-reuter opened this issue May 1, 2024 · 5 comments
Assignees

Comments

@m-reuter
Copy link
Member

m-reuter commented May 1, 2024

Description

Currently docker build workflow seem to be broken:

https://github.com/Deep-MI/FastSurfer/actions/runs/8897578099

Maybe this is still not adjusted to the current build workflow? It started when I published a release, the CPU version build (but did not upload, which could be because this version is already published there, or because it does not understand the all-tags flag?).

The GPU version never builds.

We should discuss how we want this to work in the future and fix it. One issue is that optimally the version that is uploaded to docker should also be the image that was tested with out test pipeline. So maybe we should disable the workflow?

@dkuegler
Copy link
Member

dkuegler commented May 1, 2024

deleted my comment that was incorrect.

@dkuegler
Copy link
Member

dkuegler commented May 1, 2024

So the message is

System.IO.IOException: No space left on device : '/home/runner/runners/2.316.0/_diag/Worker_20240430-181019-utc.log'

No space is not an issue we can easily solve. Maybe large runners. Alternatively, this can also be run on private runners instead of on github runners...

@dkuegler
Copy link
Member

dkuegler commented May 2, 2024

I had another look at the CPU build and that is due to a bug in the script

Run docker push --all-tags ***/fastsurfer:cpu-v.2.2.0
  docker push --all-tags ***/fastsurfer:cpu-v.2.2.0
  shell: /usr/bin/bash -e {0}
tag can't be used with --all-tags/-a
Error: Process completed with exit code 1.

@dkuegler
Copy link
Member

dkuegler commented May 2, 2024

I just realized we are a bit lucky, because re-building these images would have changed the (versioned) static images for Fastsurfer. That means same version docker Images may have lead to different images based on when they were pulled...

@m-reuter
Copy link
Member Author

m-reuter commented May 2, 2024

I stoped automated runs of this workflow in dev and stable for now. Once we decided how to do this in the future, we can delete those files.

@m-reuter m-reuter closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants