Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic from handling error during download and informaing client web app via notification queue #5

Merged
merged 10 commits into from
Jul 10, 2023

Conversation

deepaerial
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #5 (f73de4b) into master (e23792f) will increase coverage by 0.73%.
The diff coverage is 97.95%.

❗ Current head f73de4b differs from pull request most recent head 77608c7. Consider uploading reports for the commit 77608c7 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   91.94%   92.68%   +0.73%     
==========================================
  Files          18       18              
  Lines         633      656      +23     
==========================================
+ Hits          582      608      +26     
+ Misses         51       48       -3     
Impacted Files Coverage Δ
ytdl_api/datasource.py 92.77% <90.90%> (-0.57%) ⬇️
ytdl_api/callbacks.py 100.00% <100.00%> (ø)
ytdl_api/constants.py 92.59% <100.00%> (+0.28%) ⬆️
ytdl_api/dependencies.py 96.29% <100.00%> (+0.14%) ⬆️
ytdl_api/downloaders.py 98.24% <100.00%> (+7.33%) ⬆️
ytdl_api/queue.py 83.33% <100.00%> (ø)
ytdl_api/schemas/models.py 100.00% <100.00%> (ø)

@deepaerial deepaerial merged commit 4664d07 into master Jul 10, 2023
@deepaerial deepaerial deleted the ffmpeg_error_handling branch July 10, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants