Raise exception on failure rather than SIGPIPE signal #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing this allows us to gracefully attempt a reconnection. Otherwise, we'll never know (since false can be returned both in the case of message failure and in the case where no message is returned)
|
@matthill could you rename |
|
Looks good otherwise. |
|
It's late in the night here, I'll have a look tomorrow morning and merge. 💤 |
|
OK. This is done. FYI, I didn't throw exceptions for all the C++ wrappers (e.g., put, peek, list_tubes, etc). Not because we shouldn't, just laziness I suppose. |
|
thanks @matthill 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #30