Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Open/Close Event #191

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

dvonthenen
Copy link
Contributor

@dvonthenen dvonthenen commented Mar 8, 2024

Proposed changes

Addresses issue: #187

Implements Open/Close events along with a Raw Unhandled event message when you have access to raw bytes. This could be useful for wanting to handle messages that aren't implemented yet.

Updated all examples to make use of the Open/Close event. The Unhandled event wont trigger until we have a new event that is introduced that this SDK doesn't handle (ie you should not see this event at all).

Types of changes

What types of changes does your code introduce to the community Go SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NA

@dvonthenen dvonthenen merged commit 359cfa9 into deepgram:main Mar 8, 2024
1 check passed
@dvonthenen dvonthenen deleted the implement-open-close branch March 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants