Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Field in Metadata as Optional #336

Merged

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Mar 7, 2024

Proposed changes

Set a few Options properties as Optional if there is a chance they could be null. A user reported that these values may have been empty. Not sure if this is a true bug or not, but it wouldn't hurt to make these optional.

Also, adds in an example of LiveClient connection reuse.

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NA

@davidvonthenen davidvonthenen changed the title [HOLD] Set Field in Metadata as Optional Set Field in Metadata as Optional Mar 8, 2024
@davidvonthenen davidvonthenen merged commit 2a7eaeb into deepgram:main Mar 8, 2024
1 check passed
@davidvonthenen davidvonthenen deleted the metadata-optional-field branch March 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants