Added the 'placeholder' write_csv func, fixes #1542 #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipkent
requested changes
Nov 29, 2021
pyintegration/deephaven2/table.py
Outdated
Comment on lines
92
to
95
| def write_csv(self: Table, path: str, cols: List[str] = []) -> None: | ||
| try: | ||
| _JTableTools.writeCsv(self._j_table, path, *cols) | ||
| except Exception as e: | ||
| raise DHError("write csv failed.") from e | ||
|
|
There was a problem hiding this comment.
I don't think we want this method on the table. We support many data formats and have finally started packaging each format into its own module. By having this method here, we have decided that CSV is somehow more special than the other formats, and we are willing to add it to the table API. I think the method in the CSV module is sufficient. If it isn't, we can easily add a method here in the future. It is harder to take a method away from here.
A write_csv func with miniaml number of params as a temporary fillgap for future full-featured implementation
chipkent
approved these changes
Dec 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A write_csv func with miniaml number of params as a temporary fillgap
for future full-featured implementation