-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update to lerna 7.x #1417
Conversation
- Removed `useWorkspaces` flag (no longer used) - Removed 'useNx' flag (NX seems to work in the latest) - Add provenance flag to .npmrc - Fixes deephaven#1235 - Tested `npm start`, `npm test`, and `npm run build` steps and ensured they all worked correctly
Codecov Report
@@ Coverage Diff @@
## main #1417 +/- ##
=======================================
Coverage 45.71% 45.71%
=======================================
Files 511 511
Lines 35065 35065
Branches 8767 8767
=======================================
Hits 16029 16029
Misses 18985 18985
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. |
- lerna v7 now uses the npm workspaces config by default - Remove the `packages` field in lerna.json which was overriding this and no longer necessary
Have you tried publishing an alpha version from this branch? Should probably do that to ensure the provenance stuff works |
There is also an issue w/ caching and build. I ran a build, changed And another issue w/ nx is it causes See #1011 (comment) for previous issues |
I'll just add back the |
- There were still some issues with using nx: deephaven#1011 (comment)
Need to add |
- Followed the instructions on https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions - Not sure why I pushed this without setting this flag at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the action change will need to merge before we can validate this publishes properly, but looks like it should based on the failed publish saying it needs the id-token
permission
useWorkspaces
flag (no longer used)npm start
,npm test
, andnpm run build
steps and ensured they all worked correctly