-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Theming - Inline svgs #1651
Conversation
would I then have to specify an INLINE_THEME.TS file to replace the icons if I, as a third party theme write was trying to create one? I imagined it would have just been like variable as part of theme: --icon-whatever: url("svg path blah blah blah fill="var(--some-color)"...") and then before you insert the variables/on theme change you resolve it to the actual color |
@dsmmcken You can just define the svg css var in the theme .css files. Since it gets loaded after the inlinesvgs, it will take precedence |
9dc5e1f
to
c30c1fe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
+ Coverage 46.62% 46.66% +0.04%
==========================================
Files 597 599 +2
Lines 36620 36660 +40
Branches 9172 9184 +12
==========================================
+ Hits 17073 17107 +34
- Misses 19495 19501 +6
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e7f36df
to
aa1cbbc
Compare
aa1cbbc
to
a164b70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little bit of cleanup. Looks good overall.
No description provided.