Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unmerged lora integration test #1110

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Add unmerged lora integration test #1110

merged 1 commit into from
Sep 26, 2023

Conversation

rohithkrn
Copy link
Contributor

No description provided.

@rohithkrn rohithkrn requested review from zachgk, frankfliu and a team as code owners September 25, 2023 18:27
lanking520
lanking520 reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since all changes are in the testing code, could you push to a DJLServing repo branch and show a dryrun with pipeline to see if test passed?

.github/workflows/llm_integration.yml
@@ -127,7 +127,7 @@ jobs:
with:
python-version: '3.10.x'
- name: Install pip dependencies
run: pip3 install requests numpy
run: pip3 install requests numpy huggingface_hub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to install this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using snapshot_download function to download adapters on the fly.
https://github.com/deepjavalibrary/djl-serving/pull/1110/files#diff-1348e5a6c0a696af2fa5904cc01e2bd27c060d427dcf3d30997f8f53201c74ccR490

@rohithkrn
Copy link
Contributor Author

I did run a test log - https://github.com/deepjavalibrary/djl-serving/actions/runs/6281012471/job/17058929176

@rohithkrn rohithkrn merged commit 6ec5b88 into deepjavalibrary:master Sep 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohithkrn @lanking520