Separate AbstractSymbolBlock from AbstractBlock #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the AbstractSymbolBlock inherits from AbstractBlock. However, the AbstractBlock parameters system and getParameters implies that it is always possible to get the parameters for a block. While this should be true for a correctly written DJL block, it is not always true to symbol blocks. So, this change separates them to ensure that trying to get parameters when it is not possible returns the exception reflecting that the operation is unsupported. The shared functionality between AbstractSymbolBlock and AbstractBlock was moved to a common base class, AbstractBaseBlock.
Codecov Report
@@ Coverage Diff @@
## master #1555 +/- ##
============================================
- Coverage 72.08% 70.73% -1.35%
- Complexity 5126 5377 +251
============================================
Files 473 502 +29
Lines 21970 23479 +1509
Branches 2351 2552 +201
============================================
+ Hits 15838 16609 +771
- Misses 4925 5592 +667
- Partials 1207 1278 +71
Continue to review full report at Codecov.
|
frankfliu
reviewed
Apr 7, 2022
engines/mxnet/mxnet-engine/src/main/java/ai/djl/mxnet/engine/MxSymbolBlock.java
Show resolved
Hide resolved
engines/pytorch/pytorch-engine/src/main/java/ai/djl/pytorch/engine/PtSymbolBlock.java
Show resolved
Hide resolved
frankfliu
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the AbstractSymbolBlock inherits from AbstractBlock. However, the
AbstractBlock parameters system and getParameters implies that it is always
possible to get the parameters for a block. While this should be true for a
correctly written DJL block, it is not always true for symbol blocks.
So, this change separates them to ensure that trying to get parameters when it
is not possible returns the exception reflecting that the operation is
unsupported. The shared functionality between AbstractSymbolBlock and
AbstractBlock was moved to a common base class, AbstractBaseBlock.