Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xgb] Avoid download cudf dependency at build time #1694

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

frankfliu
Copy link
Contributor

Change-Id: I35a5b5cf91cda9095369f35b7b609a78070b50b3

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: I35a5b5cf91cda9095369f35b7b609a78070b50b3
@frankfliu frankfliu requested a review from zachgk as a code owner June 5, 2022 00:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2022

Codecov Report

Merging #1694 (7217d9e) into master (bb5073f) will decrease coverage by 1.45%.
The diff coverage is 65.44%.

@@             Coverage Diff              @@
##             master    #1694      +/-   ##
============================================
- Coverage     72.08%   70.63%   -1.46%     
- Complexity     5126     5520     +394     
============================================
  Files           473      521      +48     
  Lines         21970    24431    +2461     
  Branches       2351     2648     +297     
============================================
+ Hits          15838    17256    +1418     
- Misses         4925     5864     +939     
- Partials       1207     1311     +104     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../ai/djl/modality/cv/translator/YoloTranslator.java 8.33% <0.00%> (-0.50%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.38% <0.00%> (-0.31%) ⬇️
... and 278 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f867faa...7217d9e. Read the comment docs.

@frankfliu frankfliu merged commit 6592af5 into deepjavalibrary:master Jun 5, 2022
@frankfliu frankfliu deleted the xgb branch June 5, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants