Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added json array support. Implement init json #3612

Merged
merged 11 commits into from
Feb 23, 2024

Conversation

grysgreat
Copy link

The implementation of abacus json for array, object arbitrary combination support. Implements a more concise way to construct the string type in json objects,

Implements the init module in the output json tree except the readin part.

Linked Issue

Fix #3611

Any changes of core modules? (ignore if not applicable)

  • None

@grysgreat grysgreat changed the title Json abacus Added json array support. Implement init json Feb 6, 2024
@grysgreat grysgreat changed the title Added json array support. Implement init json Feature: Added json array support. Implement init json Feb 6, 2024
Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add annotations in *.h, you should describe the related variables in printing functions.

@pxlxingliang
Copy link
Collaborator

Please add annotations in *.h, you should describe the related variables in printing functions.

We plan to add a document to describe the meaning of each parameter.

@pxlxingliang pxlxingliang merged commit c9c0c7a into deepmodeling:develop Feb 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further support for objects needs to be added for json array
3 participants