Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: simplified Parallel_2d interface #4237

Merged
merged 12 commits into from
May 30, 2024

Conversation

jinzx10
Copy link
Collaborator

@jinzx10 jinzx10 commented May 25, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Unit Tests and/or Case Tests for my changes

  • The unit test for BLACS functions are redesigned to be more informative.

What's changed?

Parallel_2D, which is the base class of Parallel_Orbitals, has its user interface simplified in order to facilitate the use of 2d block-cyclic distrubtion.

Any changes of core modules? (ignore if not applicable)

No.

@mohanchen mohanchen added the Refactor Refactor ABACUS codes label May 26, 2024
@jinzx10 jinzx10 marked this pull request as ready for review May 28, 2024 11:08
Copy link
Collaborator

@mohanchen mohanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!!

@mohanchen mohanchen merged commit c4c99e1 into deepmodeling:develop May 30, 2024
13 checks passed
@jinzx10 jinzx10 deleted the parallel_2d_cleanup_stage2 branch May 30, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Refactor ABACUS codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants