Repository navigation
Replies: 1 comment
|
The classification half is confirmed, and it is deliberate rather than accidental — which changes what the fix should be.
if (/\b413\b|failed to buffer the request body:\s*length limit exceeded|payload too large|request body too large/i.test(message)) return 'INVALID_REQUEST'So any 413, plus the common proxy phrasings, lands on Which means the real defects in your report are the two you ranked below the classification:
On your proposal's component breakdown, one thing I would change: reporting per-component byte sizes ( Two cautions for the report as filed:
|
Uh oh!
There was an error while loading. Please reload this page.
Observed failure
A long-running session in DSH Desktop displayed:
Observed around 2026-10-19 10:51 UTC+08. The response body was nginx HTML; there was no actionable byte-size diagnosis or continuation path.
Verified environment (redacted)
totalTokens=161995,cacheReadTokens=161536.dsh_session_log, and whether a modern CLI already corrects this specific case. Local session size/token counts must not be confused with HTTP Content-Length.Proposed upstream improvement
The
dsh_session_logunbounded-suffix problem was already addressed in PR #5168 / 0.1.7-rc.2 (field cap and prefix delivery). This report requests a broader fallback:messages, tool definitions/results, extension fields, attachments), with secrets/prompt content excluded from diagnostics.REQUEST_BODY_TOO_LARGEcode rather than a genericINVALID_REQUEST. Preserve ordinary400 invalid tool schema,401,429and 5xx behavior.Suggested regression cases
dsh_session_logdisabled, proving total-body sizing works independently.dsh_session_logcap.Related prior work
Happy to share a metadata-only, post-serialization byte breakdown with maintainers if there is a recommended debug hook.
All reactions