Repository navigation
Replies: 1 comment
|
The second mount happens after an await. Nothing re-checks that the fiber is still active.
The fix belongs on this side, not in Cordis: either mount both children in one synchronous turn — they do not depend on each other — or re-check activity after the await before the second What I could not check from here: what triggered your reload (a Source read at |
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
The desktop host can die during a plugin hot-reload with
CordisError: cannot create effect on inactive context(codeINACTIVE_EFFECT). The error is raised insideFiber._reloadwhiledsh-desktop-hostre-applies the bundle; the host process then exits and the desktop app quits.Stack trace (from
crash-<ts>-main.log)The companion
crash-<ts>-web-boot.logadds:Environment
@deepseek-ai/dsh-desktop0.2.1-rc.2To reproduce
Not deterministic. Observed once, during a window in which the loader was reloading plugin entries (a plugin config patch had just been written). It looks like a race between
Fiber._reloadand context disposal: the reloaded entry'sapplycallback (dsh-desktop-host/lib/index.js:80) callsctx.plugin(...)after its fiber context has already been deactivated.Additional context
%APPDATA%/@deepseek-ai/dsh-desktop/logs).N entries did not activate.All reactions