Repository navigation
Replies: 2 comments
你这条我核到了,逐字仍在——而且它比"过时注释"更该修1. 现状(
|
|
Re-checked both items against Item 2 is gone, for an unrelated reason
Worth saying plainly: that commit predates this report. The row was not corrected — it was deleted along with everything around it. I am not claiming any credit for it. Item 1 still stands, and it moved
A second instance of the same class, since the first one is now mootWhile re-checking I found another line that has gone the same way:
The The One more, lower confidence
Why I keep finding these in the same shapeAll of these are prose that survived a type or behavior change in code. The suggestion from the original post still seems like the cheapest fix: a check that greps the instruction files and package READMEs for identifiers with zero hits in Still happy to open a PR for the two concrete lines if that helps. |
Uh oh!
There was an error while loading. Please reload this page.
Found while porting a plugin from 0.1.2 to 0.2.0. Both items are prose that survived a type removal, and the first one bites harder than a stale comment normally would because the file is instruction material for agents.
Measured on
639ed015(0.2.0-rc.2).1.
packages/client/AGENTS.md:104still tells implementers to handlechunkrow/*(in
## Conversation Node discipline)chunkrowhas zero hits in any.ts/.tsxunderpackages/(4341 files). The event types were removed by two edges: v1→v2 folded the stream into the settled assistant event, and from format v2 on one physical row holds exactly one event —historyRecordFirstSeq()andhistoryRecordLastSeq()now both returnrecord.event.seq(packages/api/session-controller/src/client/sessions/history-records.ts:24-35).Why this one is worth fixing rather than leaving:
AGENTS.mdis injected context. An agent writing a Conversation Node Definition today reads this line and emits a branch for a type the compiler does not have. It fails loudly at build, so nothing ships broken — but it costs a debugging cycle, and the person paying it has no reason to suspect the instruction file rather than their own code. I spent that cycle; that is how I found it.Most of the line is still accurate —
SessionEventLikeis alive (81 hits), and thematch/updatediscipline is unchanged — so the fix is surgical. The replacement guidance is roughly: a Definition that consumes Assistant deltas reads the packed runs from the settled event'sdata.stream[]without expanding members.I would also re-check "Packed rows are update-only" in the same sentence. Packed runs are no longer rows at all; whether the update-only discipline still holds for a settled
assistant/messageis a semantic question I am not in a position to answer from outside.2.
packages/runtime-diagnostics/invariants/README.md:69lists a package that no longer existsSame row in
README.zh.md:69.package.jsonfiles declaring itdsh-client-hmrdsh-client-modulesdsh-client-runtimepackages/client/runtimedoes not exist on disk. (The fourclient/runtimehits in source are unrelatedsrc/client/runtime.tsfiles inside other packages.) Two live siblings in the same row is what makes this a stale entry rather than an intentional historical record — and this README's job is specifically to say which packages ship invariant companions, so a non-existent package in that table is load-bearing.Deliberately not reported
chunkrowanddsh-client-runtimealso appear under.agents/notes/proposed/and.agents/notes/implemented/(e.g.2026-07-29-durable-last-activity-index.md,2026-08-10-remote-event-delivery.md). Those are dated architecture notes — records of what was true when written. Rewriting them would destroy their value. I checked them so that this report is a list of two things to fix, not a grep dump.Suggestion, not a request
A CI check that greps the instruction files (
AGENTS.md, package READMEs) for identifiers with zero hits in.ts/.tsxwould have caught both of these at the commit that removed the types, and would have cost nothing afterwards. The hard part is the allowlist for intentionally historical prose — but.agents/notes/**looks like it would cover most of it.Happy to open a PR for the two lines if that is useful; I did not want to presume on the correct replacement wording for item 1.
All reactions