[Bug][0.2.0-rc.2] web_search: one failed query aborts the other queries and discards their (billed) results

[avpanasyuk]

Summary

In a multi-query web_search call, one failed query aborts all the other queries mid-flight and discards the results that already succeeded. The tool returns only the first error. With the DeepSeek search provider every query is a billed deepseek-v4-flash Messages turn, so the finished searches are paid for and thrown away.

Environment

• dsh 0.2.0-rc.2, @deepseek-ai/dsh-tool-web, search provider @deepseek-ai/dsh-web-search-deepseek

Where

dsh-tool-web lib/index.js:189-212, runSearchQueries:

const controller = new AbortController();
const batchSignal = AbortSignal.any([signal, controller.signal]);
...
} catch (error) {
    if (firstFailure === void 0) firstFailure = { error };
    controller.abort(error);   // cancels every sibling search still running
    throw error;
}
...
await Promise.allSettled(searches);
if (firstFailure !== void 0) throw firstFailure.error;   // successful results discarded
return mergeSearchResults(queries, results, maxResults);

Suggestion

• Drop the shared abort on a single query's failure (keep it for the caller's own signal).
• Merge the queries that succeeded and report each failed query by name in the result, e.g. query 3 failed: <reason>.
• Fail the whole call only when every query fails.

---

Found and verified against the installed 0.2.0-rc.2 sources with the help of an AI coding agent.

[PerryLink]

你的原则是对的：一个查询失败不该作废已经付费的结果

1. 这条的核心是"扇出语义"

多查询 web_search 是扇出（一次调用展开成 N 个独立查询）。你描述的行为——一个失败 ⇒ 中止其余、只返回第一个错误——在语义上等价于用了"首个错误即整体失败"，而正确做法是"全部落定（all-settled）"：

每个查询各自结算；成功的结果照常返回，失败的在同一份结果里逐条标注原因。

建议把诉求写成这一句——它不依赖具体实现，任何评审者都能判断对错。

2. 你的"计费"论据很有力，建议放大

你指出：DeepSeek 搜索提供方下每个查询都是一次计费的 deepseek-v4-flash Messages 轮次 ⇒ 已完成的搜索被付了钱却丢掉。⇒ 这把问题从"体验不佳"变成"用户为被丢弃的工作付费"，优先级完全不同。建议放在摘要第一句。

顺带一条设计建议：既然每个查询独立计费，**逐条返回（含失败原因）**同时也让用户能判断"哪一条值得重试"，而不是整体重来一次再付一遍。

3. 我核到的与没核到的（如实说明）

• 核到：该工具在 packages/web/tool-web/src/index.ts，并且文件里明确写了"单次 web_search 调用接受的查询数上限"（:44 的注释）⇒ 多查询确实是设计内行为；
• 没核到：扇出那一处的代码（我按 Promise.all/allSettled 在该包内检索无命中，说明它在别的文件或用了别的写法）。⇒ 请补一个符号名/文件，这样维护者不必先找。

4. 请补三样

1. 扇出处的符号（哪个函数展开这些查询）；
2. 当次的实际返回（只含第一个错误的那份结果原文）——它是"其余结果被丢弃"的直接证据；
3. 版本：你写 0.2.0-rc.2；⚠️ 当前最新是 0.2.1-alpha.1 ⇒ 请确认扇出语义在新版是否已改。

5. 关于可复现性（这条很容易做成确定性复现）

不必等真实失败：只要让其中一个查询命中一个必然失败的条件（例如空查询、超长查询、或不可达的提供方端点），就能验证"其余查询是否仍返回"。建议把它写成一个两步复现（第 1 步 3 个正常查询 ⇒ 全返回；第 2 步 2 正常 + 1 必失败 ⇒ 期望返回 2 条 + 1 条错误）。

一条边界

我确认的是多查询是设计内行为（有明确上限注释）这一点。"一个失败会中止其余"这一行为以你的实测为准——我没有对真实提供方调用过该工具。

[avpanasyuk]

Answers to the three asks, checked on master at d743267 (the 0.2.1-alpha.2 release merge):

1. Symbol: runSearchQueries in packages/web/tool-web/src/search.ts:231-256, called from the tool's execute at :367. It lives in search.ts, not index.ts, which is why the search there came up empty. It does call Promise.allSettled (:253), but only to let the siblings settle after controller.abort(error) (:249); :254 then throws firstFailure.error, and mergeSearchResults never runs.
2. Returned text: I did not keep the tool result from the failing call, so I will not quote one from memory. From the code, execute throws, and the result is that one error, the first failing query's, with nothing from the queries that succeeded.
3. Version: unchanged in 0.2.1-alpha.2; the line numbers above are from that commit.

Agreed on the all-settled framing.