Add caching of datasets in DataSilo #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timoeller
reviewed
Dec 18, 2019
farm/data_handler/data_silo.py
Outdated
| self._initialize_data_loaders() | ||
|
|
||
| def _get_checkpoint_checksum(self): | ||
| checkpoint_dict = { | ||
| "train_filename": self.processor.train_filename |
There was a problem hiding this comment.
self.processor.train_filename could be similar for different datasets.
We might want to cache dependant on the data dir (or data_dir + train_filename) passed to the processor, because this should be good identifiers for a dataset
farm/data_handler/data_silo.py
Outdated
| def _save_dataset_to_cache(self): | ||
| checksum = self._get_checkpoint_checksum() | ||
|
|
||
| cache_dir = Path(f"cache/data_silo_{checksum}") |
There was a problem hiding this comment.
what about adding the data_dir here so people understand what kind of data lies in cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.