Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional num_training_steps setting #437

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Conditional num_training_steps setting #437

merged 1 commit into from
Jun 30, 2020

Conversation

PhilipMay
Copy link
Contributor

see #436

@PhilipMay PhilipMay mentioned this pull request Jun 29, 2020
Closed
tholor
tholor approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks for improvement!

@tholor tholor added enhancement New feature or request part: optimizer Optimizer labels Jun 30, 2020
@tholor tholor merged commit 14c857e into deepset-ai:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request part: optimizer Optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilipMay @tholor