Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel dataprocessing #45

Merged
merged 15 commits into from
Aug 16, 2019
Merged

Add parallel dataprocessing #45

merged 15 commits into from
Aug 16, 2019

Conversation

Timoeller
Copy link
Contributor

@Timoeller Timoeller commented Aug 6, 2019

This PR addresses #26
Multiprocessing works well and fast.
Problems:

  • When logging 3 random Samples it prints sample.features = None, but in debugging it has features and also starts training the NN....
  • Tqdm progressbar is missing in parallel mode
  • It OOMs when calling _featurize_samples() in processor.py on full SQuAD dataset.
    I remember having similar issues (using a lot of memory but not OOM) with a single process on SQuAD, too.
    Please review

@Timoeller Timoeller self-assigned this Aug 6, 2019
@tholor tholor changed the title WIP: Add parallel dataprocessing Add parallel dataprocessing Aug 16, 2019
@tholor tholor assigned tholor and unassigned Timoeller Aug 16, 2019
@tholor tholor merged commit b7e381d into master Aug 16, 2019
@tholor tholor deleted the parallel_dataproc branch August 16, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants