Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI jobs #714

Closed
lalitpagaria opened this issue Jan 6, 2021 · 5 comments
Closed

Simplify CI jobs #714

lalitpagaria opened this issue Jan 6, 2021 · 5 comments
Assignees
Labels
type:feature New feature or request

Comments

@lalitpagaria
Copy link
Contributor

lalitpagaria commented Jan 6, 2021

Current CI job have following issues -

  • Frequent OOM
  • Only test Linux build
  • Only text Python 3.7 build
  • Missing coverage run
  • Missing mypy on rest_api module
  • PR feedback about code formatting is very slow

I have following suggestions -

  1. Use solution similar to Azure pipeline to test build on Linux, MacOS and Windows (Also we need to tag some tests with env as well, like faiss tests may fail on Windows so with tag we can disable them)
  2. Use Tox to test build on all python supported versions (3.6, 3.7, 3.8 and 3.9)
  3. Use Black or Flake8 along with mypy and pylint, static code checker in separate CI job to get fast code feedback
  4. Use coverage to collect code coverage information via pytest (for first we will not block merge, but later merge can me blocked if PR does not have good code coverage)
  5. Move slow tests to separate CI jobs to mitigate OOM issue.
  6. Enable parallel test run

Please correct or suggest better options as well.

@lalitpagaria
Copy link
Contributor Author

@tholor There are steady increase of downloads from Windows users. I think I would be good idea setup CI on Windows platform as well.
image

@lalitpagaria
Copy link
Contributor Author

Same also true for downloads for different python versions as well.
image

@lalitpagaria
Copy link
Contributor Author

Adding article about how @jina-ai done it.

https://hanxiao.io/2021/01/24/Speedup-CI-Workflow-in-Github-Actions-via-Strategy-Matrix/

@lalitpagaria
Copy link
Contributor Author

After adding MilvusDocumentStore number of tests and test run time increased significantly. We would need fast feedback CI pipeline -
image

@tholor tholor assigned tanaysoni and unassigned tholor Feb 2, 2021
@oryx1729
Copy link
Contributor

resolved by #825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants