Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preprocessing.md #1087

Merged
merged 1 commit into from
May 23, 2021
Merged

Update preprocessing.md #1087

merged 1 commit into from
May 23, 2021

Conversation

Avi777
Copy link
Contributor

@Avi777 Avi777 commented May 23, 2021

Correct variable name from 'd' to 'doc' in line 134.

Proposed changes:

  • Minor variable name change in documentation.

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

Correct variable name from 'd' to 'doc' in line 134.
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot for spotting and fixing @Avi777

@tholor tholor merged commit c4ee32d into deepset-ai:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants