Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating pre-commit-config to remove python version #2884

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Updating pre-commit-config to remove python version #2884

merged 1 commit into from
Jul 26, 2022

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Jul 26, 2022

Related Issue(s): #2882

Proposed changes:

  • Remove the python version from the pre-commit-config

Pre-flight checklist

@sjrl sjrl requested a review from ZanSara July 26, 2022 14:09
@sjrl
Copy link
Contributor Author

sjrl commented Jul 26, 2022

@ZanSara Removing the python version worked for me on MacOS!

@ZanSara ZanSara added type:bug Something isn't working ignore-for-release-notes PRs with this flag won't be included in the release notes. labels Jul 26, 2022
ZanSara
ZanSara approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZanSara ZanSara merged commit 128d1e2 into master Jul 26, 2022
@ZanSara ZanSara deleted the issue-2882 branch July 26, 2022 16:14
@julian-risch julian-risch mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjrl @ZanSara