Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip file conversion if file type is not supported #456

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Skip file conversion if file type is not supported #456

merged 3 commits into from
Oct 1, 2020

Conversation

lalitpagaria
Copy link
Contributor

To address #453

@lalitpagaria
Copy link
Contributor Author

@tholor PR is ready for review. Done bit of refactoring and added support for docx files as well as it was straight forward.

tholor
tholor reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for working on it. Only minor comments.

haystack/preprocessor/utils.py Outdated Show resolved Hide resolved
haystack/preprocessor/utils.py Outdated Show resolved Hide resolved
haystack/preprocessor/utils.py Outdated Show resolved Hide resolved
@lalitpagaria
Copy link
Contributor Author

Addressed comments. Please check if looks fine then merge :)

tholor
tholor approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thx!

@tholor tholor merged commit 9b58374 into deepset-ai:master Oct 1, 2020
@lalitpagaria lalitpagaria deleted the ignore_non_permitted_files branch October 1, 2020 12:52
@tholor tholor mentioned this pull request Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lalitpagaria @tholor