-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow filtering documents on all fields (v2) #4773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments but overall looks good to me. For the sake of being an old broken record, I would have probably shipped the safe operators and the docs flattening in two separated PRs 😄
Ugh good point... I didn't realize we needed the safe operators until I tested on flat Documents, but in hindsight that's true. Thanks for the reminder! One PR at a time I'll learn to notice 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related Issues
MemoryDocumentStore
filtering to ease retrieval #4838Proposed Changes:
How did you test it?
Notes for the reviewer
Related to #4768, but it's not necessary to wait for it.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.