Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Document v2 JSON serialization #4863

Merged
merged 15 commits into from
May 15, 2023
Merged

fix: Document v2 JSON serialization #4863

merged 15 commits into from
May 15, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented May 9, 2023 •
edited
Loading

Related Issues

Proposed Changes:

  • Adds DocumentEncoder and DocumentDecoder
  • Add tests

How did you test it?

  • Local test run
  • CI

Notes for the reviewer

n/a

@ZanSara ZanSara requested a review from a team as a code owner May 9, 2023 17:40
@ZanSara ZanSara requested review from bogdankostic and removed request for a team May 9, 2023 17:40
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels May 9, 2023
@ZanSara ZanSara added the 2.x Related to Haystack v2.0 label May 9, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 9, 2023 •
edited
Loading

Coverage Status

Coverage: 37.899% (+0.2%) from 37.72% when pulling b996be2 on v2-document-table-json into 73380b1 on main.

@ZanSara ZanSara marked this pull request as draft May 10, 2023 11:20
@ZanSara ZanSara marked this pull request as ready for review May 12, 2023 09:44
bogdankostic
bogdankostic approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ZanSara ZanSara merged commit 8fbfca9 into main May 15, 2023
@ZanSara ZanSara deleted the v2-document-table-json branch May 15, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdankostic bogdankostic bogdankostic approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document.to/from_json (v2) doesn't work with dataframes, arrays and paths
3 participants
@ZanSara @coveralls @bogdankostic