Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docstrings update in web.py #4921

Merged
merged 1 commit into from
May 18, 2023
Merged

docstrings update in web.py #4921

merged 1 commit into from
May 18, 2023

Conversation

dfokina
Copy link
Contributor

@dfokina dfokina commented May 15, 2023

Corrected spelling and added GoogleAPI

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@dfokina dfokina requested a review from a team as a code owner May 15, 2023 15:19
@dfokina dfokina requested review from vblagoje and removed request for a team May 15, 2023 15:19
@github-actions github-actions bot added the type:documentation Improvements on the docs label May 15, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 15, 2023 •
edited
Loading

Coverage Status

Coverage: 38.572%. Remained the same when pulling a1834ad on websearch_docstrings into df55ec5 on main.

@dfokina
web.py docstring update
a1834ad 
Corrected spelling and added GoogleAPI
vblagoje
vblagoje approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfokina dfokina merged commit 401520b into main May 18, 2023
@dfokina dfokina deleted the websearch_docstrings branch May 18, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfokina @coveralls @vblagoje