Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filter value optional in REST API #497

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Make filter value optional in REST API #497

merged 1 commit into from
Oct 16, 2020

Conversation

tholor
Copy link
Member

@tholor tholor commented Oct 16, 2020

Let's allow again null as filter value (for backward compatibility).

Example:

{
    "questions": [
        "Who is the father of Arya?"
    ],
    "filters": {"test":null},
    "top_k_retriever": 2
}

Currently, this is failing and causes trouble with older integrations.

@tholor
Copy link
Member Author

tholor commented Oct 16, 2020

FYI @tanaysoni

@tholor tholor merged commit 4a77dc7 into master Oct 16, 2020
@julian-risch julian-risch deleted the allow_null_filter branch November 15, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant