Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow setting java options when launching Elasticsearch / OpenSearch #5002

Merged
merged 6 commits into from
May 25, 2023
Merged

feat: Allow setting java options when launching Elasticsearch / OpenSearch #5002

merged 6 commits into from
May 25, 2023

Conversation

bogdankostic
Copy link
Contributor

Related Issues

Proposed Changes:

This PR adds the option to set java opts when launching an Elasticsearch or OpenSearch docker container. Also it adds the option to delete a running Weaviate container when calling launch_weaviate.

How did you test it?

Notes for the reviewer

This is needed for benchmarking as we need to set custom java opts when executing bigger indexing runs. Otherwise, the containers might run out of memory.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@github-actions github-actions bot added the type:documentation Improvements on the docs label May 23, 2023
@bogdankostic bogdankostic mentioned this pull request May 23, 2023
Closed
@coveralls
Copy link
Collaborator

coveralls commented May 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5069751927

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 39.587%
Files with Coverage Reduction New Missed Lines %
utils/doc_store.py 30 27.59%
Totals Coverage Status
Change from base Build 5067531118: 0.1%
Covered Lines: 8864
Relevant Lines: 22391
💛 - Coveralls

@bogdankostic bogdankostic marked this pull request as ready for review May 24, 2023 06:23
@bogdankostic bogdankostic requested a review from a team as a code owner May 24, 2023 06:23
@bogdankostic bogdankostic requested review from masci and removed request for a team May 24, 2023 06:23
vblagoje
vblagoje reviewed May 24, 2023
View reviewed changes
haystack/utils/doc_store.py Outdated
],
shell=True,

java_opts_str = ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-liner perhaps?

@vblagoje vblagoje self-requested a review May 25, 2023 08:27
vblagoje
vblagoje approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdankostic bogdankostic merged commit aaab925 into main May 25, 2023
@bogdankostic bogdankostic deleted the launch_docstore_options branch May 25, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

@masci masci Awaiting requested review from masci masci is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdankostic @coveralls @vblagoje