fix: import_utils fetch_archive_from_http - improve url parsing for fetching archive from http

[malte-aws]

Related Issues

• fixes Import utils fetch_archive_from_http url parsing URL format assumption #5198

Proposed Changes:

The extension of the archive was determined by splitting the URL at "." using rpartition and then using the string to the right of the "." as the file extension.

This pull request uses urllib.parse.urlparse to split the URL into its components. Then I use splitext to split the archive extension from the path in the URL.

How did you test it?

Manual test with the To Reproduce instruction from #5198

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
• I documented my code
• I ran pre-commit hooks and fixed any issue

[CLAassistant]

All committers have signed the CLA.

[anakin87]

Hello @malte-aws and thanks for the PR, that is useful and appreciated! 👍

Some suggestions:

• the CI is failing because of black and pylint. If you install precommit, it can automatically solve these small style problems.
• I would extract the logic and create a function get_filename_extension_from_url (just an example)
• Now you should add some unit tests for this function in https://github.com/deepset-ai/haystack/blob/main/test/others/test_utils.py (testing for example one URL ending with an extension and another similar to the URL given at Import utils fetch_archive_from_http url parsing URL format assumption #5198 (comment))

Let us know if you need any help and thanks again!

[malte-aws]

Hi @anakin87,

thank you for the feedback.

I addressed the improvements by

1. Running pre-commit
2. Extracting the code that gets the filename and extension into a separate function
3. Added unit test covering the code contribution.

Kind regards
Malte

[coveralls]

Pull Request Test Coverage Report for Build 5448745686

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 288 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.008%) to 43.939%

---

Files with Coverage Reduction	New Missed Lines	%
utils/import_utils.py	19	43.1%
document_stores/faiss.py	116	18.68%
document_stores/pinecone.py	153	51.37%

Totals
Change from base Build 5425580157:	-0.008%
Covered Lines:	10087
Relevant Lines:	22957

---

💛 - Coveralls

[anakin87]

This PR is in a very good state.

It would be great if you could add a test for a "normal" URL, such as http://www.mysite.com/resources/myfile.zip

[anakin87]

Looks good to me!

Thank you once again for your first PR on Haystack 🥳