Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow filtering on list fields in InMemoryDocumentStore with all operators #5208

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

bogdankostic
Copy link
Contributor

Related Issues

Proposed Changes:

This PR adds support for filtering on list fields in InMemoryDocumentStore for the following operators

  • $in/$nin
  • $gt/$gte
  • $lt/$lte

How did you test it?

I removed the skip mark on the tests. These tests are passing now.

Notes for the reviewer

Checklist

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5378065119

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 83 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 43.039%

Files with Coverage Reduction New Missed Lines %
document_stores/filter_utils.py 83 41.91%
Totals Coverage Status
Change from base Build 5377187594: -0.03%
Covered Lines: 9759
Relevant Lines: 22675

💛 - Coveralls

Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ZanSara ZanSara merged commit 8c63e29 into main Jun 29, 2023
@ZanSara ZanSara deleted the inmemorydocstore_filters branch June 29, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta data filtering with InMemory doc store and Embedding Retriever
3 participants