fix: install inference in REST API tests
#5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanSara
changed the title
inference in restapi testsinference in REST API tests
github-actions
bot
added
topic:rest_api
type:documentation
ZanSara
commented
Jul 3, 2023
Comment on lines
+116
to
+119
| if isinstance(label.answer.offsets_in_document[0], Span): | ||
| offset_start_in_document = label.answer.offsets_in_document[0].start | ||
| else: | ||
| offset_start_in_document = label.answer.offsets_in_document[0].row |
There was a problem hiding this comment.
mypy was failing, so I added this block according to what the TableCell proposal specifies:
haystack/proposals/text/3875-table-cell.md
Line 210 in 1be3936
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
InMemoryDocumentStorerequiresinferenceand is used in the REST API tests. This PR adds that extra to the CI.How did you test it?
CI
Notes for the reviewer
n/a
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.